schtobia/ModernCppStarter
1
0
Fork 0
mirror of https://github.com/TheLartians/ModernCppStarter.git synced 2025-08-30 13:41:13 +02:00
Code Issues Activity

Feature/extend build dependency (#80)

Browse source 
* add build time dependency to static lib

the header only fmt lib is used to show this

* use add_test() and add a warning why

doctest_discover_tests() is only availabe if doctest is not imported with
find_packag()

* cmake-format file

* fix missed comment

* back to version 1.0

respect most review comments

* fix typo

* update used CMP package versions

* respect most review comments

no default cxx language settings
install fmt
link against fmt::fmt
export dependency too if not needed
...

* use generic expression as recommended

* Update CMakeLists.txt

Co-authored-by: Lars Melchior <TheLartians@users.noreply.github.com>

* changes acording review comments

update to current PackageProject version 1.5.0 too

* Update CMakeLists.txt

Co-authored-by: Lars Melchior <TheLartians@users.noreply.github.com>

* respect review comment

remove NOLINT comment

* back to begining

needs to use doctest cmake modules ...
it is not my idea!

Co-authored-by: Lars Melchior <TheLartians@users.noreply.github.com>
This commit is contained in:
Claus Klein 2021-02-19 09:46:11 +01:00 • committed by GitHub
parent b58e0717f4
commit 2db60f2ccb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 44 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

21
CMakeLists.txt
View file

@ -27,7 +27,14 @@ include(cmake/CPM.cmake)
CPMAddPackage(
NAME PackageProject.cmake
GITHUB_REPOSITORY TheLartians/PackageProject.cmake
VERSION 1.4
VERSION 1.5.0
)
CPMAddPackage(
NAME fmt
GIT_TAG 7.1.3
GITHUB_REPOSITORY fmtlib/fmt # to get an installable target
OPTIONS "FMT_INSTALL YES"
)
# ---- Add source files ----
@ -40,17 +47,16 @@ file(GLOB_RECURSE sources CONFIGURE_DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/source/
# ---- Create library ----
# Note: for header-only libraries change all PUBLIC flags to INTERFACE and create an interface
# target: add_library(Greeter INTERFACE) set_target_properties(Greeter PROPERTIES
# INTERFACE_COMPILE_FEATURES cxx_std_17)
# target: add_library(Greeter INTERFACE)
add_library(Greeter ${headers} ${sources})
set_target_properties(Greeter PROPERTIES CXX_STANDARD 17)
# being a cross-platform target, we enforce standards conformance on MSVC
target_compile_options(Greeter PUBLIC "$<$<BOOL:${MSVC}>:/permissive->")
target_compile_options(Greeter PUBLIC "$<$<COMPILE_LANG_AND_ID:CXX,MSVC>:/permissive>")
# Link dependencies (if required) target_link_libraries(Greeter PUBLIC cxxopts)
# Link dependencies
target_link_libraries(Greeter PUBLIC fmt::fmt)
target_include_directories(
Greeter PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>
@ -72,5 +78,6 @@ packageProject(
INCLUDE_DIR ${PROJECT_SOURCE_DIR}/include
INCLUDE_DESTINATION include/${PROJECT_NAME}-${PROJECT_VERSION}
VERSION_HEADER "${VERSION_HEADER_LOCATION}"
DEPENDENCIES ""
COMPATIBILITY SameMajorVersion
DEPENDENCIES "fmt 7.1.3"
)