schtobia/ModernCppStarter
1
0
Fork 0
mirror of https://github.com/TheLartians/ModernCppStarter.git synced 2025-08-30 13:41:13 +02:00
Code Issues Activity

Feature/extend build dependency (#80)

Browse source 
* add build time dependency to static lib

the header only fmt lib is used to show this

* use add_test() and add a warning why

doctest_discover_tests() is only availabe if doctest is not imported with
find_packag()

* cmake-format file

* fix missed comment

* back to version 1.0

respect most review comments

* fix typo

* update used CMP package versions

* respect most review comments

no default cxx language settings
install fmt
link against fmt::fmt
export dependency too if not needed
...

* use generic expression as recommended

* Update CMakeLists.txt

Co-authored-by: Lars Melchior <TheLartians@users.noreply.github.com>

* changes acording review comments

update to current PackageProject version 1.5.0 too

* Update CMakeLists.txt

Co-authored-by: Lars Melchior <TheLartians@users.noreply.github.com>

* respect review comment

remove NOLINT comment

* back to begining

needs to use doctest cmake modules ...
it is not my idea!

Co-authored-by: Lars Melchior <TheLartians@users.noreply.github.com>
This commit is contained in:
Claus Klein 2021-02-19 09:46:11 +01:00 • committed by GitHub
parent b58e0717f4
commit 2db60f2ccb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 44 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

11
source/greeter.cpp
View file

@ -1,19 +1,20 @@
#include <fmt/format.h>
#include <greeter/greeter.h>
using namespace greeter;
Greeter::Greeter(std::string _name) : name(_name) {}
Greeter::Greeter(std::string _name) : name(std::move(_name)) {}
std::string Greeter::greet(LanguageCode lang) const {
switch (lang) {
default:
case LanguageCode::EN:
return "Hello, " + name + "!";
return fmt::format("Hello, {}!", name);
case LanguageCode::DE:
return "Hallo " + name + "!";
return fmt::format("Hallo {}!", name);
case LanguageCode::ES:
return "¡Hola " + name + "!";
return fmt::format("¡Hola {}!", name);
case LanguageCode::FR:
return "Bonjour " + name + "!";
return fmt::format("Bonjour {}!", name);
}
}