From 7a8809648cb709199220d9bd012f7cc2a7cb334d Mon Sep 17 00:00:00 2001 From: Lars Melchior Date: Tue, 14 Apr 2020 14:43:42 +0200 Subject: [PATCH] update readme --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 3a93ba9..0f6b51d 100644 --- a/README.md +++ b/README.md @@ -81,18 +81,18 @@ See [Format.cmake](https://github.com/TheLartians/Format.cmake) for more options Yes, however you will need to change the library type to an `INTERFACE` library as documented in the [CMakeLists.txt](CMakeLists.txt). - - You are using `GLOB` to add source files in CMakeLists.txt. Isn't that evil? + - I see you are using `GLOB` to add source files in CMakeLists.txt. Isn't that evil? Glob is considered bad because changes to source files won't be automatically caught by CMakes builders and you will need remember to invoke CMake on any changes. I personally prefer the `GLOB` solution for its simplicity, but feel free to change it to explicitly listing sources. - I'm adding external dependencies to my project using CPM. Will this force users to use CPM as well? - CPM should be mostly invisible for your library users as it's self-contained and dependency free. + CPM.cmake should be invisible for your library users as it's a self-contained CMake Script. If problems do arise, they can always opt-out by defining `CPM_USE_LOCAL_PACKAGES`, which will override all calls to `CPMAddPackage` with `find_package`. - If you are using `CPMFindPackage` instead of `CPMAddPackage`, CPM will always try to use `find_package` to add packages. - This approach should be compatible with any common C++ package manager without any user intervention, however at the cost of reproducible builds. - For more info, see the [CPM.cmake documentation](https://github.com/TheLartians/CPM.cmake). + If you concerned about this, you should prefer using `CPMFindPackage` instead of `CPMAddPackage`, as then CPM will try to use `find_package` to add packages whenever possible. + `CPMFindPackage` approach should also be compatible with any common C++ package manager without modifications, however at the cost of reproducible builds. + For more information, see the [CPM.cmake documentation](https://github.com/TheLartians/CPM.cmake). - Can I configure and build my project offline?