diff --git a/include/greeter/greeter.h b/include/greeter/greeter.h index 3c8c1e8..64b6446 100644 --- a/include/greeter/greeter.h +++ b/include/greeter/greeter.h @@ -13,6 +13,7 @@ namespace greeter { * @brief A class for saying hello in multiple languages */ class GREETER_EXPORT Greeter { + protected: std::string name; public: @@ -20,7 +21,7 @@ namespace greeter { * @brief Creates a new greeter * @param name the name to greet */ - explicit Greeter(std::string name); + explicit Greeter(std::string _name); /** * @brief Creates a localized string containing the greeting diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index 0ea6a09..22195f2 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -54,7 +54,7 @@ if(NOT TEST_INSTALLED_VERSION) if(CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER_ID MATCHES "GNU") target_compile_options(Greeter PUBLIC -Wall -Wpedantic -Wextra -Werror) elseif(MSVC) - # XXX target_compile_options(Greeter PUBLIC /W4 /WX) + target_compile_options(Greeter PUBLIC /W4 /WX) target_compile_definitions(GreeterTests PUBLIC DOCTEST_CONFIG_USE_STD_HEADERS) endif() endif()