schtobia/ModernCppStarter
1
0
Fork 0
mirror of https://github.com/TheLartians/ModernCppStarter.git synced 2025-10-31 18:21:35 +01:00
Code Issues Activity

changes acording review comments

Browse source 
update to current PackageProject version 1.5.0 too
This commit is contained in:
ClausKlein 2021-02-16 13:23:13 +01:00
parent f76aa76a81
commit b483a1eb5a
4 changed files with 11 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

5
standalone/source/main.cpp
View file

@ -8,8 +8,6 @@
// NOLINTNEXTLINE(modernize-use-trailing-return-type)
int main(int argc, char** argv) {
// prevent warning: initialization of 'languages' with static storage duration may throw an
// exception that cannot be caught [cert-err58-cpp]
const std::unordered_map<std::string, greeter::LanguageCode> languages{
{"en", greeter::LanguageCode::EN},
{"de", greeter::LanguageCode::DE},
@ -17,8 +15,6 @@ int main(int argc, char** argv) {
{"fr", greeter::LanguageCode::FR},
};
// prevent warning: do not use pointer arithmetic
// [cppcoreguidelines-pro-bounds-pointer-arithmetic]
cxxopts::Options options(*argv, "A program to welcome the world!");
std::string language;
@ -40,7 +36,6 @@ int main(int argc, char** argv) {
return 0;
}
// prevent warning: do not use 'else' after 'return' [readability-else-after-return]
if (result["version"].as<bool>()) {
std::cout << "Greeter, version " << GREETER_VERSION << std::endl;
return 0;