schtobia/ModernCppStarter
1
0
Fork 0
mirror of https://github.com/TheLartians/ModernCppStarter.git synced 2025-09-01 06:30:52 +02:00
Code Issues Activity

respect review comments

Browse source 
respect master project settings if any
This commit is contained in:
ClausKlein 2021-02-05 13:49:51 +01:00
parent d25ad76019
commit cd175563a3
2 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

18
CMakeLists.txt
View file

@ -20,9 +20,11 @@ endif()
# ---- Project settings ----
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS NO)
if(NOT DEFINED CMAKE_CXX_STANDARD)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS NO)
endif()
# ---- Add dependencies via CPM ----
# see https://github.com/TheLartians/CPM.cmake for more info
@ -36,8 +38,8 @@ CPMAddPackage(
VERSION 1.4
)
find_package(fmt)
if(NOT TARGET fmt::fmt)
find_package(fmt 6)
if(NOT TARGET fmt::fmt-header-only)
# FIXME this add a target without namespace! CK
CPMAddPackage(
NAME fmt
@ -67,7 +69,7 @@ target_sources(Greeter PRIVATE ${headers} ${sources})
target_compile_options(Greeter PUBLIC "$<$<BOOL:${MSVC}>:/permissive->")
# Link dependencies (if required)
target_link_libraries(Greeter PRIVATE fmt::fmt)
target_link_libraries(Greeter PRIVATE fmt::fmt-header-only)
target_include_directories(
Greeter PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>
@ -90,7 +92,5 @@ packageProject(
INCLUDE_DESTINATION include/${PROJECT_NAME}-${PROJECT_VERSION}
VERSION_HEADER "${VERSION_HEADER_LOCATION}"
# semicolon separated list of the project's dependencies
DEPENDENCIES fmt
# install your library with a namespace! (do NOT add extra '::')
NAMESPACE ${PROJECT_NAME}
# XXX DEPENDENCIES fmt
)