1
0
Fork 0
mirror of https://github.com/TheLartians/ModernCppStarter.git synced 2025-09-03 23:50:53 +02:00

one more try with dll on windows

cleanup code too
This commit is contained in:
ClausKlein 2021-02-16 18:25:02 +01:00
parent d7a5e850a0
commit f59c0cfbee
4 changed files with 10 additions and 22 deletions

View file

@ -8,8 +8,6 @@
// NOLINTNEXTLINE(modernize-use-trailing-return-type)
int main(int argc, char** argv) {
// prevent warning: initialization of 'languages' with static storage duration may throw an
// exception that cannot be caught [cert-err58-cpp]
const std::unordered_map<std::string, greeter::LanguageCode> languages{
{"en", greeter::LanguageCode::EN},
{"de", greeter::LanguageCode::DE},
@ -17,8 +15,6 @@ int main(int argc, char** argv) {
{"fr", greeter::LanguageCode::FR},
};
// prevent warning: do not use pointer arithmetic
// [cppcoreguidelines-pro-bounds-pointer-arithmetic]
cxxopts::Options options(*argv, "A program to welcome the world!");
std::string language;
@ -40,7 +36,6 @@ int main(int argc, char** argv) {
return 0;
}
// prevent warning: do not use 'else' after 'return' [readability-else-after-return]
if (result["version"].as<bool>()) {
std::cout << "Greeter, version " << GREETER_VERSION << std::endl;
return 0;