schtobia/MyModernCppStarter
1
0
Fork 0
Code Issues Pull requests Activity

Make Greeter link privately to fmt (#109)

Browse source 
Greeter depends on fmt only in it's implementation file, therefore this
dependency can be private.
This commit is contained in:
Dale Lukas Peterson 2021-03-21 13:17:43 -07:00 • committed by GitHub
parent 6132c67bd2
commit 9e54d3ce9a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
CMakeLists.txt
View file

@ -52,7 +52,7 @@ set_target_properties(Greeter PROPERTIES CXX_STANDARD 17)
target_compile_options(Greeter PUBLIC "$<$<COMPILE_LANG_AND_ID:CXX,MSVC>:/permissive>")
# Link dependencies
target_link_libraries(Greeter PUBLIC fmt::fmt)
target_link_libraries(Greeter PRIVATE fmt::fmt)
target_include_directories(
Greeter PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>