Added (enforced) shellcheck

.gitlab-ci.yml

@@ -0,0 +1,7 @@
+---
+test:shellcheck:
+  stage: test
+  image: koalaman/shellcheck-alpine
+  script:
+    shellcheck *.sh
+...

bootstrap-root.sh

@@ -38,10 +38,12 @@ apt-get update  \
 	&&  apt-file update
 
 # node related
+# shellcheck disable=SC2086
 curl $CURLOPT https://deb.nodesource.com/setup_14.x | bash -
 apt-get install -y nodejs
 
 # python3 related
+# shellcheck disable=SC2086
 curl $CURLOPT https://bootstrap.pypa.io/get-pip.py | python3
 
 pip install ranger-fm
@@ -50,5 +52,6 @@ pip install ranger-fm
 
 cargo install --root /usr/local --git https://github.com/mookid/diffr
 
+# shellcheck disable=SC2086
 curl $CURLOPT -o /usr/local/sbin/cleanup.sh https://gist.github.com/schtobia/f02deeaf2fd20b23ae9fcf0f451cc858/raw/cleanup.sh \
 	&& chmod u+x /usr/local/sbin/cleanup.sh

bootstrap-user.sh

@@ -7,10 +7,10 @@ TMPDIR=$(mktemp -u -p "$HOME" -d dotfiles.XXXXX) && \
 	[ -r "$TMPDIR/.gitmodules" ] && cp -vi "$TMPDIR/.gitmodules" "$HOME"
 [ -d "$HOME/.cfg" ] && \
 	git --git-dir="$HOME/.cfg/" --work-tree="$HOME" config status.showUntrackedFiles no && \
-	(cd $HOME && \
+	(cd "$HOME" && \
 		git --git-dir="$HOME/.cfg/" --work-tree="$HOME" checkout -- . && \
 		git --git-dir="$HOME/.cfg/" --work-tree="$HOME" submodule update --init --remote --recursive --rebase)
-rm -rf $TMPDIR
+rm -rf "$TMPDIR"
 
 pip install --user -r https://github.com/schtobia/bootstrap/raw/master/requirements.txt
 

bootstrap.sh

@@ -4,7 +4,9 @@ set -e
 CURLOPT=${CURLOPT:-"--location --remote-time --show-error --silent --fail --tlsv1.2"}
 
 # root part
+# shellcheck disable=SC2086
 curl $CURLOPT https://github.com/schtobia/bootstrap/raw/master/bootstrap-root.sh | sudo -SEH bash -
 
 # userspace part
+# shellcheck disable=SC2086
 curl $CURLOPT https://github.com/schtobia/bootstrap/raw/master/bootstrap-user.sh | bash -