From 84d4b50404b965773f028f93e25b73d49563760c Mon Sep 17 00:00:00 2001 From: Tobias Schmidl Date: Fri, 22 Sep 2023 08:17:49 +0200 Subject: [PATCH] feat: don't require build-args for the labels, just write the directly via --label --- Makefile | 3 ++- dockerfile | 13 ++----------- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/Makefile b/Makefile index 630f7c9..fdb7fb8 100644 --- a/Makefile +++ b/Makefile @@ -5,10 +5,11 @@ DOCKER := docker BUILDER := ${DOCKER} buildx TAG := git.schmidl.dev/schtobia/buildimage +URL:= https://${TAG} VERSION = $(shell git describe --tags --always --dirty) build: dockerfile - @${BUILDER} build --build-arg=GIT_COMMIT=$(shell git describe --always) --build-arg=VERSION=${VERSION} --build-arg=TIMESTAMP="$(shell date -u -Iseconds)" -t ${TAG} -t ${TAG}:${VERSION} . + @${BUILDER} build --label org.opencontainers.image.revision=$(shell git describe --always) --label org.opencontainers.image.version=${VERSION} --label org.opencontainers.image.created="$(shell date -u -Iseconds)" --label org.opencontainers.image.source=https://${TAG}.git --label org.opencontainers.image.url=https://${TAG} -t ${TAG} -t ${TAG}:${VERSION} . .PHONY: publish publish: build diff --git a/dockerfile b/dockerfile index 48ec00a..4878406 100644 --- a/dockerfile +++ b/dockerfile @@ -5,19 +5,14 @@ FROM debian:bullseye-slim ARG DEBIAN_FRONTEND=noninteractive -ARG GIT_COMMIT -ARG VERSION -ARG TIMESTAMP LABEL org.opencontainers.image.licenses="AGPL-3.0-or-later" \ org.opencontainers.image.base.name="docker.io/debian:bullseye-slim" \ -org.opencontainers.image.title=buildimage \ -org.opencontainers.image.source="https://git.schmidl.dev/schtobia/buildimage" \ -org.opencontainers.image.url="https://git.schmidl.dev/schtobia/buildimage" +org.opencontainers.image.title=buildimage # editorconfig-checker-disable RUN apt update \ - && apt install --assume-yes --no-install-recommends \ + && apt install --assume-yes --no-install-recommends --quiet \ build-essential \ dpkg-sig \ git \ @@ -30,7 +25,3 @@ RUN useradd -rm builder USER builder WORKDIR /workdir - -LABEL org.opencontainers.image.revision=${GIT_COMMIT} -LABEL org.opencontainers.image.version=${VERSION} -LABEL org.opencontainers.image.created=${TIMESTAMP}