schtobia/ModernCppStarter
1
0
Fork 0
mirror of https://github.com/TheLartians/ModernCppStarter.git synced 2025-10-31 02:01:33 +01:00
Code Issues Activity

Don't use glob

Browse source 
From cmake itself:
```
Note We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate. The CONFIGURE_DEPENDS flag may not work reliably on all generators, or if a new generator is added in the future that cannot support it, projects using it will be stuck. Even if CONFIGURE_DEPENDS works reliably, there is still a cost to perform the check on every rebuild.
```

A standard template shouldn't even consider using glob.
This commit is contained in:
Nathan Lanza 2020-04-16 15:06:36 -04:00 • committed by GitHub
parent 581612e44f
commit 8309eb7f98
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
CMakeLists.txt
View file

@ -30,20 +30,15 @@ CPMAddPackage(
VERSION 1.0 VERSION 1.0
) )
# ---- Add source files ----
# Note: globbing sources is considered bad practice as CMake's generators may not detect new files automatically.
# Keep that in mind when changing files, or explicitly mention them here.
FILE(GLOB_RECURSE headers CONFIGURE_DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/include/*.h")
FILE(GLOB_RECURSE sources CONFIGURE_DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/source/*.cpp")
# ---- Create library ---- # ---- Create library ----
# Note: for header-only libraries change all PUBLIC flags to INTERFACE and create an interface target: # Note: for header-only libraries change all PUBLIC flags to INTERFACE and create an interface target:
# add_library(Greeter INTERFACE) # add_library(Greeter INTERFACE)
# set_target_properties(Greeter PROPERTIES INTERFACE_COMPILE_FEATURES cxx_std_17) # set_target_properties(Greeter PROPERTIES INTERFACE_COMPILE_FEATURES cxx_std_17)
add_library(Greeter ${headers} ${sources}) add_library(Greeter
${CMAKE_CURRENT_SOURCE_DIR}/include/greeter.h
${CMAKE_CURRENT_SOURCE_DIR}/source/greeter.cpp)
set_target_properties(Greeter PROPERTIES CXX_STANDARD 17) set_target_properties(Greeter PROPERTIES CXX_STANDARD 17)