schtobia/ModernCppStarter
1
0
Fork 0
mirror of https://github.com/TheLartians/ModernCppStarter.git synced 2025-08-30 21:51:12 +02:00
Code Issues Activity

windoof dll export is not as easy as it should!

Browse source
This commit is contained in:
ClausKlein 2021-02-15 19:50:26 +01:00
parent ab83f20c29
commit ae2d022801
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
include/greeter/greeter.h
View file

@ -13,6 +13,7 @@ namespace greeter {
* @brief A class for saying hello in multiple languages
*/
class GREETER_EXPORT Greeter {
protected:
std::string name;
public:
@ -20,7 +21,7 @@ namespace greeter {
* @brief Creates a new greeter
* @param name the name to greet
*/
explicit Greeter(std::string name);
explicit Greeter(std::string _name);
/**
* @brief Creates a localized string containing the greeting

2
test/CMakeLists.txt
View file

@ -54,7 +54,7 @@ if(NOT TEST_INSTALLED_VERSION)
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER_ID MATCHES "GNU")
target_compile_options(Greeter PUBLIC -Wall -Wpedantic -Wextra -Werror)
elseif(MSVC)
# XXX target_compile_options(Greeter PUBLIC /W4 /WX)
target_compile_options(Greeter PUBLIC /W4 /WX)
target_compile_definitions(GreeterTests PUBLIC DOCTEST_CONFIG_USE_STD_HEADERS)
endif()
endif()